tools: add benchmark for loading sets#535
Merged
Merged
Conversation
Claude review of PR #535 (5e6bef2)Suggestions
Nits
|
pzmarzly
force-pushed
the
push-voqxqossrrll
branch
from
66e1e63 to
64c0686
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
qdeslandes
force-pushed
the
push-voqxqossrrll
branch
from
64c0686 to
34cef1d
Compare
qdeslandes
requested changes
May 12, 2026
Comment on lines
+243
to
+247
| ret = bf_chain_flush(chainName.c_str()); | ||
| if (ret < 0) { | ||
| state.SkipWithError("failed to flush chain"); | ||
| break; | ||
| } |
Contributor
There was a problem hiding this comment.
Use
{
benchmark::ScopedPauseTiming pause(state); // Pauses timing
ret = bf_chain_flush(chainName.c_str());
if (ret < 0) {
state.SkipWithError("failed to flush chain");
break;
}
}
So you don't have to manually set the iteration time.
Contributor
Author
There was a problem hiding this comment.
ScopedPauseTiming was only merged a month ago, and is not available yet in gbenchmark shipped by my distro. Fun! google/benchmark#2157
I'll use PauseTiming and ResumeTiming functions.
pzmarzly
force-pushed
the
push-voqxqossrrll
branch
from
34cef1d to
fc95024
Compare
pzmarzly
force-pushed
the
push-voqxqossrrll
branch
from
fc95024 to
5e6bef2
Compare
Contributor
Author
|
@claude review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Measure time it takes to load a chain that contains a large set. This will be a common operation (especially since sets can update).
Requires #532.